Skip to content

Conversation

benjeffery
Copy link
Contributor

Closes #203
Closes #396
Closes #388

Requires #401 for the plink2zarr comments to make sense.

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2025

Coverage Status

coverage: 98.286%. remained the same
when pulling f337022 on benjeffery:deps-docs
into 479ec84 on sgkit-dev:main.

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few refinements needed

```

This will install the programs ``vcf2zarr`` and ``vcf_partition``
into your local Python path. You may need to update your $PATH to call the
For bioconda users, the package is available in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should clarify that this includes all dependencies bundled in, i.e., equivalent to running pip install bio2zarr[all]

conda install -c bioconda bio2zarr
```

This will install the programs ``vcf2zarr``, ``vcf_partition``, ``tskit2zarr`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will install the programs ``vcf2zarr``, ``vcf_partition``, ``tskit2zarr`
This will install the programs ``vcf2zarr``, ``vcf_partition``, ``tskit2zarr``

Comment on lines 38 to 39
Windows is not currently directly supported. We recommend the use
of Windows Subsystem for Linux (WSL) Please comment on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Windows is not currently directly supported. We recommend the use
of Windows Subsystem for Linux (WSL) Please comment on
Windows support is preliminary, partial and needs to be fully documented. We recommend trying the bioconda packages in the first instance, and if this doesn't work try using
Windows Subsystem for Linux (WSL). Please comment on

[this issue](https://github.com/sgkit-dev/bio2zarr/issues/174) if you would
like to see Windows support for bio2zarr.
like to see direct Windows support for bio2zarr.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
like to see direct Windows support for bio2zarr.
if you would like to see improved Windows support for bio2zarr, or would like to help out with this.

@benjeffery
Copy link
Contributor Author

Fixed up

@jeromekelleher jeromekelleher added this pull request to the merge queue May 23, 2025
Merged via the queue into sgkit-dev:main with commit f6fbb1c May 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants